refactor: 맵 상세 페이지를 새로운 API 명세에 맞게 마이그레이션 #980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2yunseong
requested changes
Oct 26, 2023
frontend/src/types/response-v2.ts
Outdated
Comment on lines
4
to
6
| extends Omit<MapItem, 'mapDrawing' | 'sharingMapId' | 'notice' | 'managerEmail'> { | ||
| mapDrawing: string; | ||
| } |
There was a problem hiding this comment.
명세보면, slackUrl이 포함되어있어서 해당 부분 추가해줘야 될 것 같습니다!
일단은 저도 MapItemResponseV2에 slackUrl 프로퍼티를 추가했는데, 생각해보면 MapItem에 넣어야 겠더라구요.
위 부분은 Map관련 API 전부 이전한 이후 변경해도 좋다 생각합니다.
따라서 merge할 때 유념하면 될 것 같아요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
구현 기능
ManagerMapDetail)에 사용되는 api를 v2로 마이그레이션 했습니다.GET /api/maps/{mapId})를 대상으로 마이그레이션 했습니다.논의하고 싶은 내용
Before
After
Close #977